impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit
Date Mon, 05 Jun 2017 17:38:51 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7077/1/be/src/common/status.h
File be/src/common/status.h:

Line 181:   Status(const TStatus& status);
> Should this one be explicit, too?
Done


Line 189:   Status(const apache::hive::service::cli::thrift::TStatus& hs2_status);
> And this one?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message