impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit
Date Mon, 05 Jun 2017 17:38:32 GMT
Hello Marcel Kornacker,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7077

to look at the new patch set (#3).

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................

IMPALA-5433: Mark single-argument Status c'tors as explicit

Avoid unexpected errors by marking Status c'tors as explicit. Per Google
style guide, >1 arg c'tors are not marked as explicit to allow for
copy-initialization.

Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Testing: compiled impalad and be-test.
---
M be/src/common/status.h
M be/src/exec/hdfs-parquet-scanner.cc
M be/src/runtime/coordinator.cc
M be/src/util/codec.cc
4 files changed, 15 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/7077/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>

Mime
View raw message