impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5432: Remove invalid DCHECK from SetMemLimitExceeded
Date Mon, 05 Jun 2017 17:35:17 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5432: Remove invalid DCHECK from SetMemLimitExceeded
......................................................................


IMPALA-5432: Remove invalid DCHECK from SetMemLimitExceeded

- SetMemLimitExeeded conditionally sets query_status to
  MEM_LIMIT_EXCEEDED if the current query_status is Ok.
- The DCHECK in SetMemLimitExceed unconditionally checked if the
  query_status is set to MEM_LIMIT_EXCEEDED.
  - It is possible that the query_status was set by some previous
  error that isn't a MEM_LIMIT_EXCEEDED error.

Change-Id: I1c03048ad15739baf7e68ca8d50930f3c45e71c5
Reviewed-on: http://gerrit.cloudera.org:8080/7075
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/runtime-state.cc
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c03048ad15739baf7e68ca8d50930f3c45e71c5
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Sherman <jfs@arcadiadata.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Sherman <jfs@arcadiadata.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message