impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-5357: Patch boost time duration bug
Date Mon, 05 Jun 2017 16:36:06 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-5357: Patch boost time_duration bug
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7056/1/source/boost/boost-1.57.0-patches/0002-IMPALA-5357.patch
File source/boost/boost-1.57.0-patches/0002-IMPALA-5357.patch:

Line 65: +           typename v_type = std::time_t >
> Possibly, though I think arguably it makes sense to keep the change to from
SG. I'm not familiar enough with the build numbers to +2, but I'm convinced of the validity
of the patch.


-- 
To view, visit http://gerrit.cloudera.org:8080/7056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idee1b84bd7d3515c98c482e691119d04dc71f929
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message