impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-5357: Patch boost time duration bug
Date Mon, 05 Jun 2017 16:33:58 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5357: Patch boost time_duration bug
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7056/1/source/boost/boost-1.57.0-patches/0002-IMPALA-5357.patch
File source/boost/boost-1.57.0-patches/0002-IMPALA-5357.patch:

Line 65: +           typename v_type = std::time_t >
> Can this patch be simplified to just the two changed lines in this file: in
Possibly, though I think arguably it makes sense to keep the change to from_time_t above as
the removal of the static_cast<long> improves portability, even if we plan on always
using systems where time_t == long. Given that this patch also went in upstream, I think it's
reasonable to keep it together. If you feel strongly I can probably remove the changes to
the first file.


-- 
To view, visit http://gerrit.cloudera.org:8080/7056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idee1b84bd7d3515c98c482e691119d04dc71f929
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message