impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5420: Skip ACL fetch if the acl bit is not set.
Date Sat, 03 Jun 2017 01:10:42 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5420: Skip ACL fetch if the acl bit is not set.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7071/1/fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java
File fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java:

Line 287:     FileStatus fileStatus = fs.getFileStatus(path);
> Isn't this an RPC as well? Are we really saving anything?
Oh nvm, I see we need to do this one any way.


-- 
To view, visit http://gerrit.cloudera.org:8080/7071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96ff681fe2dddb7b777758cc49a66cc5eb741b4d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message