impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5355: Fix the order of Sentry roles and privileges
Date Sat, 03 Jun 2017 00:37:27 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-5355: Fix the order of Sentry roles and privileges

Patch Set 1:

File fe/src/main/java/org/apache/impala/catalog/

PS1, Line 1203: Preconditions.checkState(role.checkVersionConsistency());
> I don't think this check is needed here. I don't see how, given that the ca
This change was removed as Alex suggested.

Line 1214:   public Role removeRoleGrantGroup(String roleName, String groupName)
> This approach looks correct, but I wonder if we should instead solve the de

PS1, Line 1224: Preconditions.checkState(role.checkVersionConsistency());
> same here
This change was removed as Alex suggested.
File fe/src/main/java/org/apache/impala/catalog/

Line 122:     Preconditions.checkState(result.checkVersionConsistency());
> add an error message here, something to indicate the problem.
This change was removed as Alex suggested.
File tests/authorization/

PS1, Line 30: TestImpaladRestart
> Add description of what kind of tests we plan on adding in this class.
I moved this change to another file.

PS1, Line 50: test_impalad_restart
> This function name is a bit generic and it's not clear what this test case 

PS1, Line 51: correclty
> typo: correctly

PS1, Line 57: assert
> It's also important for this test that there are privileges associated with

PS1, Line 64: sleep(10)
> I believe there is a better way to detect this. I think there is a metric (

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I7072e95b74952ce5a51ea1b6e2ae3e80fb0940e0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-HasComments: Yes

View raw message