impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5384: Simplify coordinator locking protocol
Date Fri, 02 Jun 2017 21:56:48 GMT
Marcel Kornacker has uploaded a new patch set (#2).

Change subject: IMPALA-5384: Simplify coordinator locking protocol

IMPALA-5384: Simplify coordinator locking protocol

This changes the locking behavior of the coordinator in
the following way:
- the central lock_ is replaced with a state variable
  protected by a lock; the state distinguishes between
  execution and (multiple) error states and is used
  to maintain the overall query status
- data structures related to stats about Insert operations
  are moved into a new class InsertExecState

- adds DescriptorTbl::CreateHdfsTableDescriptor to avoid
  having to create an entire DescriptorTbl during INSERT
  finalization (when only a descriptor for the output
  table is needed)
- removes TQueryExecRequest.desc_tbl, there's already
  a home for it in TQueryContext.desc_tbl

Change-Id: I6a79aa38e529d0994921906b2beb796fd589a7e3
M be/src/benchmarks/
M be/src/exec/
M be/src/exec/
M be/src/exec/data-sink.h
M be/src/exec/
M be/src/exec/
M be/src/exec/
M be/src/exec/
M be/src/runtime/CMakeLists.txt
M be/src/runtime/
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/
M be/src/runtime/coordinator.h
M be/src/runtime/
M be/src/runtime/descriptors.h
M be/src/runtime/
A be/src/runtime/
A be/src/runtime/insert-exec-state.h
M be/src/runtime/
M be/src/runtime/
M be/src/runtime/runtime-state.h
M be/src/service/
M be/src/service/client-request-state.h
M be/src/service/
M be/src/service/
M be/src/service/
M be/src/service/
M be/src/service/impala-server.h
M be/src/testutil/
M be/src/util/counting-barrier.h
M common/thrift/Frontend.thrift
M fe/src/main/java/org/apache/impala/service/
M fe/src/test/java/org/apache/impala/planner/
33 files changed, 1,127 insertions(+), 932 deletions(-)

  git pull ssh:// refs/changes/65/7065/2
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6a79aa38e529d0994921906b2beb796fd589a7e3
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Marcel Kornacker <>

View raw message