impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4892: Session ID included in error message
Date Fri, 02 Jun 2017 03:22:34 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4892: Session ID included in error message
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7054/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

PS1, Line 1085: Substitute
one more nit (sorry, my rough example code had this same issue) - please explicitly construct
a Status() here. We should mark the Status c'tors as explicit.


-- 
To view, visit http://gerrit.cloudera.org:8080/7054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I721951aaf2425da62e61d65150e462a83716b02e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Steve Carlin <stevec@arcadiadata.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message