impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading
Date Fri, 02 Jun 2017 00:53:18 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7045/3/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

Line 901:         analysisCtx = new AnalysisContext(impaladCatalog_.get(), queryCtx,
> Doesn't this destroy the analysisCtx.timeline_ and effectively hide how lon
Ugh, I think you're right. But I don't think we want to put the atomic ref into the analysisctx
- we don't want to read two different catalogs at different points during analysis by dereferencing
the atomic ref at different times. Probably needs AnalysisContext.setCatalog() or similar.


-- 
To view, visit http://gerrit.cloudera.org:8080/7045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I574d69fa75198499523dc291fbbd0d7e3d8d968f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message