impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
Date Fri, 02 Jun 2017 00:03:26 GMT
John Russell has posted comments on this change.

Change subject: IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE

Patch Set 1:


Addressed all the comments from Lars.
File docs/topics/impala_create_table.xml:

Line 388:       <codeph>CREATE TABLE AS SELECT</codeph> operation. Creating data
files that are
> I think it's important to understand that the source table property does no
OK. I will mention that in a subsequent paragraph talking about cases where SORT BY does or
doesn't apply.

Line 389:       sorted is most useful for Parquet tables, where the metadata includes the
minimum and
> Here it should be clear that the information is stored in the file metadata

Line 390:       maximum values for each column in each data file. Grouping data values together
> Technically, statistics are stored per RowGroup. Impala only writes 1 rowgr

Line 400:       evident with Parquet tables.
> We could mention here, that other file formats don't have statistics inside

Line 412:       tools that creat HDFS files, Impala does not guarantee or rely on the data
> typo

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd571cd8840368edb327d16d27192458838ef234
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <>
Gerrit-Reviewer: Alan Choi <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: John Russell <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-HasComments: Yes

View raw message