impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5419: Check for cancellation when building hash tables
Date Fri, 02 Jun 2017 00:03:08 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-5419: Check for cancellation when building hash tables
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7047/1/be/src/exec/partitioned-hash-join-builder.cc
File be/src/exec/partitioned-hash-join-builder.cc:

PS1, Line 690: RETURN_IF_ERROR(state->GetQueryStatus());
Wouldn't this return if it got cancelled?


-- 
To view, visit http://gerrit.cloudera.org:8080/7047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8047f532f55dc0118f7a843c91275f752c8a190d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message