impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads
Date Thu, 01 Jun 2017 22:45:54 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................


IMPALA-5350: Tidy up thread groups for finst exec threads

Put all per-finst threads (profile report, exec thread, async build
thread, scanner threads) together in one group "fragment-execution", and
add finst ID to all their names.

Remove -<tid> suffix from thread names and add a separate column with it
to /threadz web page.

Testing: eyeballed with a join query.

Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Reviewed-on: http://gerrit.cloudera.org:8080/6951
Reviewed-by: Henry Robinson <henry@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/blocking-join-node.cc
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/kudu-scan-node.cc
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/fragment-instance-state.h
M be/src/runtime/query-state.cc
M be/src/util/thread.cc
M www/thread-group.tmpl
8 files changed, 40 insertions(+), 26 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Henry Robinson: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins

Mime
View raw message