impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe McDonnell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case
Date Thu, 01 Jun 2017 21:08:56 GMT
Joe McDonnell has posted comments on this change.

Change subject: IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case
......................................................................


Patch Set 2:

> > > See IMPALA-5403, which is something we should do in the near
 > > term,
 > > > so it might be best to piggy back on that rather than another
 > > > one-off.
 > >
 > > I was thinking that since Isilon works with the HDFS commandline,
 > > it might make sense for query_test/test_hdfs_fd_caching.py to run
 > > on Isilon, even though caching is not happening. We expect this
 > not
 > > to crash Impala whether or not file handle cache is on.
 > 
 > That makes sense. Actually, those commands should work fine on S3
 > as well, so maybe the test doesn't ever need to be skipped?

Changed the test to run on all platforms (except local filesystem). I will run a test on S3
to make sure it works.

-- 
To view, visit http://gerrit.cloudera.org:8080/7020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee982fa5e964f6c8969b2eb7e5f3eca89e793b3a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message