impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Date Thu, 01 Jun 2017 20:30:29 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................


Patch Set 1:

(14 comments)

http://gerrit.cloudera.org:8080/#/c/7038/1/testdata/workloads/functional-query/queries/QueryTest/subplans.test
File testdata/workloads/functional-query/queries/QueryTest/subplans.test:

Line 1: ====
Let's merge these tests into nested-types-subplan.test. I'll add comments whether a test should
be merged or removed due to duplicate coverage.

For the tests to be merged, please don't just append them at the end, but look for the appropriate
place. The tests in nested-types-subplan.test try to systematically cover all exec nodes inside
a subplan.


Line 3: # Test a union inside a subplan with some constant operands.
Merge into nested-types-subplan.test


Line 36: # Test an order by + limit (topn node) inside a subplan.
Remove. Already covered in nested-types-subplan.test


Line 50: # Test a select node inside a subplan.
Remove. Already covered in nested-types-subplan.test


Line 63: # Test an analytic function that requires a sort inside a subplan.
Remove. Already covered in nested-types-subplan.test


Line 87: # Test an analytic function that does not require a sort inside a subplan.
Remove. Already covered in nested-types-subplan.test


Line 110: # Test a non-grouping aggregation inside a subplan.
Remove. Already covered in nested-types-subplan.test


Line 124: SELECT c_custkey, avg(maxp)
Remove. Already covered in nested-types-subplan.test


Line 137: # Test a grouping aggregation inside a subplan.
Remove. Already covered in nested-types-subplan.test


Line 158: # Test a join inside a subplan.
Remove. Already covered in nested-types-subplan.test


Line 171: # Test a self-join inside a subplan.
Remove. Already covered in nested-types-subplan.test


Line 188: # Test a left outer join inside a subplan.
Merge into nested-types-subplan.test


Line 205: # Test a right outer join inside a subplan.
Merge into nested-types-subplan.test


Line 219: # IMPALA-2368: Test nested subplans with a non-trivial plan tree.
Merge into nested-types-subplan.test


-- 
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message