impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5137: [DOCS] Document TIMESTAMP for Kudu tables
Date Thu, 01 Jun 2017 19:32:21 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5137: [DOCS] Document TIMESTAMP for Kudu tables
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/7035/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

Line 3497:         value. The behavior of <codeph>TIMESTAMP</codeph> for Kudu
tables has some special considerations:
also we need to mention that the date ranges aren't the same. Impala supports dates within
years 1400-9999 but Kudu supports a much wider range. Clearly Impala cannot write such values
to Kudu outside its own range, but you can write such values using the Kudu API. If Impala
attempts to read values outside its supported range, then it either: (a) fails the query if
ABORT_ON_ERROR is enabled, or (b) returns NULL for those values.


http://gerrit.cloudera.org:8080/#/c/7035/1/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:

Line 1621: 					<p conref="../shared/impala_common.xml#common/kudu_blurb"/>
tabs?


http://gerrit.cloudera.org:8080/#/c/7035/1/docs/topics/impala_kudu.xml
File docs/topics/impala_kudu.xml:

Line 972: 	partition by hash (id) partitions 20,
tabs?


http://gerrit.cloudera.org:8080/#/c/7035/1/docs/topics/impala_timestamp.xml
File docs/topics/impala_timestamp.xml:

Line 459: 	partition by hash (x) partitions 16
tabs?


-- 
To view, visit http://gerrit.cloudera.org:8080/7035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib889198eb2c918c969c7613dd1ddf65a801f7926
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <todd@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message