impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads
Date Thu, 01 Jun 2017 18:20:57 GMT
Hello Alex Behm, Dan Hecht,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6951

to look at the new patch set (#3).

Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................

IMPALA-5350: Tidy up thread groups for finst exec threads

Put all per-finst threads (profile report, exec thread, async build
thread, scanner threads) together in one group "fragment-execution", and
add finst ID to all their names.

Remove -<tid> suffix from thread names and add a separate column with it
to /threadz web page.

Testing: eyeballed with a join query.

Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
---
M be/src/exec/blocking-join-node.cc
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/kudu-scan-node.cc
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/fragment-instance-state.h
M be/src/runtime/query-state.cc
M be/src/util/thread.cc
M www/thread-group.tmpl
8 files changed, 40 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/6951/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>

Mime
View raw message