Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4F9A9200CA7 for ; Wed, 31 May 2017 01:29:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4C8BD160BDC; Tue, 30 May 2017 23:29:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 92960160BC9 for ; Wed, 31 May 2017 01:29:14 +0200 (CEST) Received: (qmail 97561 invoked by uid 500); 30 May 2017 23:29:13 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 97547 invoked by uid 99); 30 May 2017 23:29:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 May 2017 23:29:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 268D31A0780 for ; Tue, 30 May 2017 23:29:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id t5EZtwp1rfVf for ; Tue, 30 May 2017 23:29:12 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 2CC935F36B for ; Tue, 30 May 2017 23:29:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v4UNTBXo001877; Tue, 30 May 2017 23:29:11 GMT Message-Id: <201705302329.v4UNTBXo001877@ip-10-146-233-104.ec2.internal> Date: Tue, 30 May 2017 23:29:11 +0000 From: "Tim Armstrong (Code Review)" To: anujphadke , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5363=3A_Reset_probe_batch__after_reaching_limit=0A?= X-Gerrit-Change-Id: Iafd621d33a4e2fac42391504566ffd8dd0e18a67 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1bd73e603fed330c139bca665b5b79b4615e55e6 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 30 May 2017 23:29:15 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-5363: Reset probe_batch_ after reaching limit ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7014/2/testdata/workloads/functional-query/queries/QueryTest/joins.test File testdata/workloads/functional-query/queries/QueryTest/joins.test: Line 734: # IMPALA-5363: Reset probe_batch_ after reaching limit. I think this test should be moved to subplans.test. We can't run against nested types in all build configurations so I think this would probably cause the old aggs and joins build to fail. Can you add the equivalent test for NLJ too? I'm not confident we have coverage for that, even though it seems to work. I ran test_nested_types.py with the code in NLJNode commented out and the test passed. -- To view, visit http://gerrit.cloudera.org:8080/7014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafd621d33a4e2fac42391504566ffd8dd0e18a67 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke Gerrit-HasComments: Yes