Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201705260305.v4Q35EJr010008@ip-10-146-233-104.ec2.internal>
Date: Fri, 26 May 2017 03:05:13 +0000
From: "Michael Ho (Code Review)" <gerrit@cloudera.org>
To: Mostafa Mokhtar <mmokhtar@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Michael Brown <mikeb@cloudera.com>, Tim Wood <twood@cloudera.com>,
        Greg Rahn <grahn@cloudera.com>, Dan Hecht <dhecht@cloudera.com>
Reply-To: kwho@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5376=3A_Loads_all_TPC-DS_tables=0A?=
In-Reply-To: <gerrit.1494621714000.Ic5277245fd20827c9c09ce5c1a7a37266ca476b9@gerrit.cloudera.org>
References: <gerrit.1494621714000.Ic5277245fd20827c9c09ce5c1a7a37266ca476b9@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Fri, 26 May 2017 03:05:19 -0000

Hello Mostafa Mokhtar,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6877

to look at the new patch set (#8).

Change subject: IMPALA-5376: Loads all TPC-DS tables
......................................................................

IMPALA-5376: Loads all TPC-DS tables

This change loads the missing tables in TPC-DS. In addition,
it also fixes up the loading of the partitioned table store_sales
so all partitions will be loaded. The existing TPC-DS queries are
also updated to use the parameters for qualification runs as noted
in the TPC-DS specification. Some hard-coded partition filters were
also removed. They were there due to the lack of dynamic partitioning
in the past. Some missing TPC-DS queries are also added to this change,
including query28 which discovered the infamous IMPALA-5251.

Having all tables in TPC-DS available paves the way for us to include
all supported TPCDS queries in our functional testing. Due to the change
in the data, planner tests and the E2E tests have different results than
before. The results of E2E tests were compared against the run done with
Netezza and Vertica. The divergence were all due to the truncation behavior
of decimal types in DECIMAL_V1.

Change-Id: Ic5277245fd20827c9c09ce5c1a7a37266ca476b9
---
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M testdata/bin/compute-table-stats.sh
M testdata/bin/generate-schema-statements.py
M testdata/datasets/tpcds/tpcds_schema_template.sql
M testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test
M testdata/workloads/functional-query/queries/QueryTest/analytic-fns-tpcds.test
M testdata/workloads/functional-query/queries/QueryTest/seq-writer.test
M testdata/workloads/tpcds/queries/count.test
A testdata/workloads/tpcds/queries/tpcds-q1.test
M testdata/workloads/tpcds/queries/tpcds-q19.test
A testdata/workloads/tpcds/queries/tpcds-q2.test
A testdata/workloads/tpcds/queries/tpcds-q23-1.test
A testdata/workloads/tpcds/queries/tpcds-q23-2.test
M testdata/workloads/tpcds/queries/tpcds-q27.test
A testdata/workloads/tpcds/queries/tpcds-q27a.test
A testdata/workloads/tpcds/queries/tpcds-q28.test
M testdata/workloads/tpcds/queries/tpcds-q3.test
M testdata/workloads/tpcds/queries/tpcds-q34.test
A testdata/workloads/tpcds/queries/tpcds-q4.test
M testdata/workloads/tpcds/queries/tpcds-q42.test
M testdata/workloads/tpcds/queries/tpcds-q43.test
M testdata/workloads/tpcds/queries/tpcds-q46.test
M testdata/workloads/tpcds/queries/tpcds-q47.test
M testdata/workloads/tpcds/queries/tpcds-q52.test
M testdata/workloads/tpcds/queries/tpcds-q53.test
M testdata/workloads/tpcds/queries/tpcds-q55.test
M testdata/workloads/tpcds/queries/tpcds-q59.test
M testdata/workloads/tpcds/queries/tpcds-q6.test
M testdata/workloads/tpcds/queries/tpcds-q61.test
M testdata/workloads/tpcds/queries/tpcds-q63.test
M testdata/workloads/tpcds/queries/tpcds-q65.test
M testdata/workloads/tpcds/queries/tpcds-q68.test
M testdata/workloads/tpcds/queries/tpcds-q7.test
M testdata/workloads/tpcds/queries/tpcds-q73.test
M testdata/workloads/tpcds/queries/tpcds-q79.test
M testdata/workloads/tpcds/queries/tpcds-q88.test
M testdata/workloads/tpcds/queries/tpcds-q89.test
M testdata/workloads/tpcds/queries/tpcds-q96.test
M testdata/workloads/tpcds/queries/tpcds-q98.test
M tests/query_test/test_mem_usage_scaling.py
M tests/query_test/test_tpcds_queries.py
41 files changed, 10,581 insertions(+), 3,960 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/6877/8
-- 
To view, visit http://gerrit.cloudera.org:8080/6877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic5277245fd20827c9c09ce5c1a7a37266ca476b9
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>