Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EE2C0200C80 for ; Thu, 25 May 2017 21:57:56 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id ECBCD160BCA; Thu, 25 May 2017 19:57:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3CAE3160BB4 for ; Thu, 25 May 2017 21:57:56 +0200 (CEST) Received: (qmail 51292 invoked by uid 500); 25 May 2017 19:57:55 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 51281 invoked by uid 99); 25 May 2017 19:57:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 May 2017 19:57:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B70A31AFE6C for ; Thu, 25 May 2017 19:57:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id AWOipcjq-0Pz for ; Thu, 25 May 2017 19:57:53 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 950345FBC1 for ; Thu, 25 May 2017 19:57:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v4PJvqcX024949; Thu, 25 May 2017 19:57:52 GMT Message-Id: <201705251957.v4PJvqcX024949@ip-10-146-233-104.ec2.internal> Date: Thu, 25 May 2017 19:57:52 +0000 From: "Bharath Vissapragada (Code Review)" To: Dimitris Tsirogiannis , Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: bharathv@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5325=3A_Do_not_update_totalHdfsBytes_/numHdfsFiles__on_Catalogd=0A?= X-Gerrit-Change-Id: I03cc6f9e9b2c03cafb87029ea0802dfdb2745be1 X-Gerrit-ChangeURL: X-Gerrit-Commit: f7a20168cd4ac55fdadc1c8d1d650822a1b987c3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 25 May 2017 19:57:57 -0000 Hello Impala Public Jenkins, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6970 to look at the new patch set (#6). Change subject: IMPALA-5325: Do not update totalHdfsBytes_/numHdfsFiles_ on Catalogd ...................................................................... IMPALA-5325: Do not update totalHdfsBytes_/numHdfsFiles_ on Catalogd We need not account these hdfs table metrics on the Catalog server as they are eventually calculated again on the Impalads while unpacking the corresponding thrift table. This fix can potentially affect the frontend tests that directly load the Catalog's version of HdfsTable without the loadFromThrift() call paths that do the accounting. That is fixed by adding a separate call that computes these values and is called from ImpaladTestCatalog.getTable(). Testing: Enough tests already cover these code paths like show stats/ table or partition refresh tests etc. No new tests are added. Change-Id: I03cc6f9e9b2c03cafb87029ea0802dfdb2745be1 --- M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java 2 files changed, 28 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/6970/6 -- To view, visit http://gerrit.cloudera.org:8080/6970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I03cc6f9e9b2c03cafb87029ea0802dfdb2745be1 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins