Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C49CE200C80 for ; Thu, 25 May 2017 19:11:53 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C3423160BCA; Thu, 25 May 2017 17:11:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 15841160BB4 for ; Thu, 25 May 2017 19:11:52 +0200 (CEST) Received: (qmail 73079 invoked by uid 500); 25 May 2017 17:11:50 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 73068 invoked by uid 99); 25 May 2017 17:11:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 May 2017 17:11:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E7E4AC0974 for ; Thu, 25 May 2017 17:11:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ddanSZ3bJuWn for ; Thu, 25 May 2017 17:11:49 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id EF5F660D89 for ; Thu, 25 May 2017 17:11:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v4PHBkIV017077; Thu, 25 May 2017 17:11:46 GMT Message-Id: <201705251711.v4PHBkIV017077@ip-10-146-233-104.ec2.internal> Date: Thu, 25 May 2017 17:11:46 +0000 From: "Matthew Jacobs (Code Review)" To: Valencia Edna Serrao , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong , Jim Apple Reply-To: mj@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5Bnative-toolchain-CR=5D_Ported_native-toolchain_to_work_on_ppc64le=0A?= X-Gerrit-Change-Id: I7931752ca497bc7a5e3cc574bbb54637f382c72a X-Gerrit-ChangeURL: X-Gerrit-Commit: 6c966fded9dbcc94499a0ca7e178da5a7cc44eb3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 25 May 2017 17:11:54 -0000 Matthew Jacobs has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6468/5/source/breakpad/breakpad-ffe3e478657dc7126fca6329dfcedc49f4c726d9-patches/0002-Build-breakpad-ffe3e47-on-ppc64le.patch File source/breakpad/breakpad-ffe3e478657dc7126fca6329dfcedc49f4c726d9-patches/0002-Build-breakpad-ffe3e47-on-ppc64le.patch: Line 1: Only in breakpad-88e-p3/: my_breakpad > I checked if any interference, of ppc64le changes in x86 code, existed by b I was hoping we could compare the sha1sum of the binary before/after the change? I don't want to hold this up if that doesn't line up, but it would give us confidence that we're not affecting the x86 bits :) -- To view, visit http://gerrit.cloudera.org:8080/6468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7931752ca497bc7a5e3cc574bbb54637f382c72a Gerrit-PatchSet: 5 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Valencia Edna Serrao Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Valencia Edna Serrao Gerrit-HasComments: Yes