Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 780CA200C8E for ; Thu, 25 May 2017 02:06:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 76A01160BD0; Thu, 25 May 2017 00:06:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BE669160BB6 for ; Thu, 25 May 2017 02:06:48 +0200 (CEST) Received: (qmail 94261 invoked by uid 500); 25 May 2017 00:06:48 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 94232 invoked by uid 99); 25 May 2017 00:06:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 May 2017 00:06:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 63C551890D4 for ; Thu, 25 May 2017 00:06:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id FHzFBUyHYNi4 for ; Thu, 25 May 2017 00:06:46 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 897005FC4D for ; Thu, 25 May 2017 00:06:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v4P06jO5029042; Thu, 25 May 2017 00:06:45 GMT Message-Id: <201705250006.v4P06jO5029042@ip-10-146-233-104.ec2.internal> Date: Thu, 25 May 2017 00:06:45 +0000 From: "Sailesh Mukil (Code Review)" To: Pooja Nilangekar , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: sailesh@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5232=3A_Parquet_reader_error_message_prints_memory_address_instead_of_value=0A?= X-Gerrit-Change-Id: I6a8f424807877c38d6f113db924cec8c68828c70 X-Gerrit-ChangeURL: X-Gerrit-Commit: ea0dd2435c145449379b5981a416346940433e77 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 25 May 2017 00:06:49 -0000 Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5232: Parquet reader error message prints memory address instead of value ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6982/2//COMMIT_MSG Commit Message: PS2, Line 8: instead of value Nit: The title can exceed 70 chars. We want the title to be on one line so we can see it in the single line commit list on github. I should have mentioned that earlier. Line 16: - num_bytes = *data_size + 1 It'll also be good to mention why you're not adding automated tests. -- To view, visit http://gerrit.cloudera.org:8080/6982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a8f424807877c38d6f113db924cec8c68828c70 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: Yes