Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BFB9D200C7E for ; Tue, 23 May 2017 22:27:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BE5AE160BA4; Tue, 23 May 2017 20:27:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 165BB160BC3 for ; Tue, 23 May 2017 22:27:27 +0200 (CEST) Received: (qmail 2302 invoked by uid 500); 23 May 2017 20:27:27 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 2286 invoked by uid 99); 23 May 2017 20:27:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 May 2017 20:27:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A62731AFA25 for ; Tue, 23 May 2017 20:27:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id rluXJfUJoPIm for ; Tue, 23 May 2017 20:27:26 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 476C75F19B for ; Tue, 23 May 2017 20:27:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v4NKRNkt007469; Tue, 23 May 2017 20:27:23 GMT Message-Id: <201705232027.v4NKRNkt007469@ip-10-146-233-104.ec2.internal> Date: Tue, 23 May 2017 20:27:23 +0000 From: "Mostafa Mokhtar (Code Review)" To: Michael Ho , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Greg Rahn , Alex Behm , Tim Wood Reply-To: mmokhtar@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Loads_all_TPC-DS_tables=0A?= X-Gerrit-Change-Id: Ic5277245fd20827c9c09ce5c1a7a37266ca476b9 X-Gerrit-ChangeURL: X-Gerrit-Commit: ef2551bbdef04f2cdc3fa90000c5567293f0f9e2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 23 May 2017 20:27:28 -0000 Mostafa Mokhtar has posted comments on this change. Change subject: Loads all TPC-DS tables ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6877/3/testdata/workloads/functional-query/queries/QueryTest/seq-writer.test File testdata/workloads/functional-query/queries/QueryTest/seq-writer.test: Line 101: where ss_sold_date_sk between 2451170 and 2451200; > To keep the test time under a reasonable amount. This change loaded way mor Can you modify the predicate to where (ss_sold_date_sk between 2451170 and 2451200) or ss_sold_date_sk is null Good to have some rows in the default partition. -- To view, visit http://gerrit.cloudera.org:8080/6877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5277245fd20827c9c09ce5c1a7a37266ca476b9 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-HasComments: Yes