Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 66535200C8C for ; Tue, 23 May 2017 04:32:39 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 64EEC160BD4; Tue, 23 May 2017 02:32:39 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AB42A160BBF for ; Tue, 23 May 2017 04:32:38 +0200 (CEST) Received: (qmail 88365 invoked by uid 500); 23 May 2017 02:32:37 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 88354 invoked by uid 99); 23 May 2017 02:32:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 May 2017 02:32:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 46980C28E3 for ; Tue, 23 May 2017 02:32:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ZJss4Nbrt50A for ; Tue, 23 May 2017 02:32:36 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id DC3125FB80 for ; Tue, 23 May 2017 02:32:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v4N2WY3i027006; Tue, 23 May 2017 02:32:34 GMT Message-Id: <201705230232.v4N2WY3i027006@ip-10-146-233-104.ec2.internal> Date: Tue, 23 May 2017 02:32:34 +0000 From: "Impala Public Jenkins (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5349=3A_flaky_NoDirsAllocationError_test=0A?= X-Gerrit-Change-Id: I023193b9ad6c6ac0ee114ad77ddf04d7d7185809 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6a31d355b02cbd147d4cf5f7faadfca01d328563 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 23 May 2017 02:32:39 -0000 Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5349: flaky NoDirsAllocationError test ...................................................................... IMPALA-5349: flaky NoDirsAllocationError test The assertion was incorrect and racy - it is ok if the write error wins the race with the Unpin() calls, causing them to fail. Change-Id: I023193b9ad6c6ac0ee114ad77ddf04d7d7185809 Reviewed-on: http://gerrit.cloudera.org:8080/6953 Reviewed-by: Henry Robinson Reviewed-by: Dan Hecht Tested-by: Impala Public Jenkins --- M be/src/runtime/buffered-block-mgr-test.cc 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Verified Henry Robinson: Looks good to me, but someone else must approve Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I023193b9ad6c6ac0ee114ad77ddf04d7d7185809 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins