Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9ABCE200C79 for ; Fri, 19 May 2017 22:59:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 992A7160BD1; Fri, 19 May 2017 20:59:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DD423160BB0 for ; Fri, 19 May 2017 22:59:42 +0200 (CEST) Received: (qmail 72763 invoked by uid 500); 19 May 2017 20:59:42 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 72741 invoked by uid 99); 19 May 2017 20:59:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 May 2017 20:59:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 5CC181A7B3A for ; Fri, 19 May 2017 20:59:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5MfW2sU4ExBZ for ; Fri, 19 May 2017 20:59:40 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id DFD285FCB9 for ; Fri, 19 May 2017 20:59:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v4JKxcVZ005367; Fri, 19 May 2017 20:59:38 GMT Message-Id: <201705192059.v4JKxcVZ005367@ip-10-146-233-104.ec2.internal> Date: Fri, 19 May 2017 20:59:38 +0000 From: "Thomas Tauber-Marshall (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs , Michael Ho , Dan Hecht Reply-To: tmarshall@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5340=3A_Query_profile_displays_stale_query_state=0A?= X-Gerrit-Change-Id: I952319b7308a24d4e2dff924199c0c771bce25b3 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2eb2b820390e10985700f74c55adaeeb62b7d23c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 19 May 2017 20:59:43 -0000 Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5340: Query profile displays stale query state ...................................................................... Patch Set 2: (1 comment) > Any good way to regression test this? Obviously its a timing issue when we'll advance query states, and without a good way to control the timing tests run the risk of either being flaky or being too permissive to catch bugs. One observation is with this change it will always be the case that after a call to ExecuteStatement (for hs2, or the equivalent for beeswax), the query will have advanced past CREATED to RUNNING or FINISHED (which was not the case before this patch) and after all rows have been fetched the state will be FINISHED. We could check for those things in tests, though I don't think they're required by the hs2 (or beeswax) spec so it may change in the future. http://gerrit.cloudera.org:8080/#/c/6923/2/be/src/service/client-request-state.h File be/src/service/client-request-state.h: PS2, Line 413: must ensure lock_ > Any chance we can DCHECK it ? From looking through the boost documentation, I don't think so. -- To view, visit http://gerrit.cloudera.org:8080/6923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I952319b7308a24d4e2dff924199c0c771bce25b3 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes