Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7370F200CA3 for ; Thu, 18 May 2017 01:42:40 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 703CB160BCB; Wed, 17 May 2017 23:42:40 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B5A8D160BBA for ; Thu, 18 May 2017 01:42:39 +0200 (CEST) Received: (qmail 19150 invoked by uid 500); 17 May 2017 23:42:38 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 19139 invoked by uid 99); 17 May 2017 23:42:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 May 2017 23:42:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5D62218055C for ; Wed, 17 May 2017 23:42:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id tVheiIEZKCob for ; Wed, 17 May 2017 23:42:36 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id F33925FE3B for ; Wed, 17 May 2017 23:42:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v4HNgY1A030245; Wed, 17 May 2017 23:42:34 GMT Message-Id: <201705172342.v4HNgY1A030245@ip-10-146-233-104.ec2.internal> Date: Wed, 17 May 2017 23:42:34 +0000 From: "Michael Ho (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Marcel Kornacker , Tim Armstrong Reply-To: kwho@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4192=3A_Disentangle_Expr_and_ExprContext=0A?= X-Gerrit-Change-Id: Iefdc9aeeba033355cb9497e3a5d2363627dcf2f3 X-Gerrit-ChangeURL: X-Gerrit-Commit: ed9327ba7ab73579d272bb6dbe8d999847d609c4 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 17 May 2017 23:42:40 -0000 Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/5483/13/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: PS13, Line 1104: const vector& filter_ctxs Should avoid using FilterContext for codegen as it's runtime state. http://gerrit.cloudera.org:8080/#/c/5483/13/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: PS13, Line 366: expr_mem_pool() not thread safe to use expr_mem_pool(). -- To view, visit http://gerrit.cloudera.org:8080/5483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefdc9aeeba033355cb9497e3a5d2363627dcf2f3 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes