Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1BB82200C7D for ; Tue, 16 May 2017 21:06:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1A307160BC1; Tue, 16 May 2017 19:06:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6142F160BA6 for ; Tue, 16 May 2017 21:06:48 +0200 (CEST) Received: (qmail 38751 invoked by uid 500); 16 May 2017 19:06:47 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 38740 invoked by uid 99); 16 May 2017 19:06:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 May 2017 19:06:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F2AC61AFF18 for ; Tue, 16 May 2017 19:06:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id LuZSdmR8yuRS for ; Tue, 16 May 2017 19:06:46 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 1BECC5FB70 for ; Tue, 16 May 2017 19:06:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v4GJ6jNw026592; Tue, 16 May 2017 19:06:45 GMT Message-Id: <201705161906.v4GJ6jNw026592@ip-10-146-233-104.ec2.internal> Date: Tue, 16 May 2017 19:06:45 +0000 From: "Sailesh Mukil (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson Reply-To: sailesh@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5331=3A_Use_new_libHDFS_API_to_address_=22Unknown_Error_255=22=0A?= X-Gerrit-Change-Id: I181e316ed63b70b94d4f7a7557d398a931bb171d X-Gerrit-ChangeURL: X-Gerrit-Commit: 1d7601553cacc6d71a2c16c0b201eceee13885fe In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 16 May 2017 19:06:49 -0000 Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" ...................................................................... Patch Set 2: > I think the more information the better. If we can determine that > one of those messages is always superseded by the get-last-exception-root-cause > msg then we can elide it, but for now it seems ok to me to have > more verbose msgs that could help debugging. Ok, makes sense. I've added it for all types of errors now. Figuring out if both the messages are redundant is not trivial, so I'm not solving that for now. -- To view, visit http://gerrit.cloudera.org:8080/6894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I181e316ed63b70b94d4f7a7557d398a931bb171d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No