Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5B22A200C7D for ; Tue, 16 May 2017 18:52:55 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 59B76160BC1; Tue, 16 May 2017 16:52:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9F185160BA6 for ; Tue, 16 May 2017 18:52:54 +0200 (CEST) Received: (qmail 66068 invoked by uid 500); 16 May 2017 16:52:53 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 66052 invoked by uid 99); 16 May 2017 16:52:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 May 2017 16:52:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1051FC0B3C for ; Tue, 16 May 2017 16:52:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id h-JHskLU2X1z for ; Tue, 16 May 2017 16:52:52 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id D521D5F5D3 for ; Tue, 16 May 2017 16:52:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v4GGqoY0023470; Tue, 16 May 2017 16:52:50 GMT Message-Id: <201705161652.v4GGqoY0023470@ip-10-146-233-104.ec2.internal> Date: Tue, 16 May 2017 16:52:50 +0000 From: "Dan Hecht (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5166=3A_clean_up_BufferPool_counters=0A?= X-Gerrit-Change-Id: I34b7f4d94c3d396ac89026c7559d6b2c6e02697c X-Gerrit-ChangeURL: X-Gerrit-Commit: 941b91b27b06117e0bbcf14dcf38dffaa96fc412 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 16 May 2017 16:52:55 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-5166: clean up BufferPool counters ...................................................................... Patch Set 6: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6690/6/be/src/runtime/bufferpool/reservation-tracker.cc File be/src/runtime/bufferpool/reservation-tracker.cc: PS6, Line 104: "InitialReservation" does that counter still exist? or is this meant to check one of the counters being added below? http://gerrit.cloudera.org:8080/#/c/6690/6/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: PS6, Line 228: Reservation=5.00 MB is it not useful to indicate how much of the reservation is actually in use as well? don't need to add it to this change but wondering if that will help with tuning reservations in extreme cases. -- To view, visit http://gerrit.cloudera.org:8080/6690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34b7f4d94c3d396ac89026c7559d6b2c6e02697c Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes