Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9749C200C7D for ; Tue, 16 May 2017 18:26:42 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 95C7C160BAC; Tue, 16 May 2017 16:26:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DE6A3160B9D for ; Tue, 16 May 2017 18:26:41 +0200 (CEST) Received: (qmail 59295 invoked by uid 500); 16 May 2017 16:26:41 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 59284 invoked by uid 99); 16 May 2017 16:26:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 May 2017 16:26:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 767831813F6 for ; Tue, 16 May 2017 16:26:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id x7m1grlnRCKV for ; Tue, 16 May 2017 16:26:39 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 108F65F3DA for ; Tue, 16 May 2017 16:26:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v4GGQbTi022593; Tue, 16 May 2017 16:26:37 GMT Message-Id: <201705161626.v4GGQbTi022593@ip-10-146-233-104.ec2.internal> Date: Tue, 16 May 2017 16:26:37 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5166=3A_clean_up_BufferPool_counters=0A?= X-Gerrit-Change-Id: I34b7f4d94c3d396ac89026c7559d6b2c6e02697c X-Gerrit-ChangeURL: X-Gerrit-Commit: 6aa8a630560296e4ec69994faefba97c2507c283 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 16 May 2017 16:26:42 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-5166: clean up BufferPool counters ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6690/3/be/src/runtime/bufferpool/buffer-pool.cc File be/src/runtime/bufferpool/buffer-pool.cc: PS3, Line 279: profile->GetOrCreateChild > Right, but why not just add that (or use the existing AddChid() pattern)? :S forgot what was in my own patch. Switched to CreateChild() and using an existing API in buffer-pool-test. I think CreateChild() is a better API than AddChild() because it doesn't require threading the ObjectPool through - there's no logical reason I can see that the child profile would have a different lifetime to its parent. http://gerrit.cloudera.org:8080/#/c/6690/3/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: PS3, Line 237: BufferPoolUsed > update Done -- To view, visit http://gerrit.cloudera.org:8080/6690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34b7f4d94c3d396ac89026c7559d6b2c6e02697c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes