Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201705151836.v4FIaEkX031802@ip-10-146-233-104.ec2.internal>
Date: Mon, 15 May 2017 18:36:14 +0000
From: "Sailesh Mukil (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Matthew Jacobs <mj@cloudera.com>, Lars Volker <lv@cloudera.com>
Reply-To: sailesh@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4764=3A_Add_Hedged_read_metrics=0A?=
In-Reply-To: <gerrit.1494818284000.Id4a5d396abb3373d352ad2df8c2272db018114da@gerrit.cloudera.org>
References: <gerrit.1494818284000.Id4a5d396abb3373d352ad2df8c2272db018114da@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Mon, 15 May 2017 18:36:20 -0000

Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-4764: Add Hedged read metrics
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6886/3/be/src/runtime/disk-io-mgr-scan-range.cc
File be/src/runtime/disk-io-mgr-scan-range.cc:

PS3, Line 349: FLAGS_use_hdfs_pread
> Why not just always get/update the metrics? It still seems valid to me. I a
I agree, however, I did this for perf reasons. The "hdfsGetHedgedReadMetrics" function calls a malloc every time it's invoked.

I didn't see any reason why we should have it allocate memory and then free it just to get the same result every time.

What do you think?


http://gerrit.cloudera.org:8080/#/c/6886/3/common/thrift/metrics.json
File common/thrift/metrics.json:

Line 563:     "description": "The total number of hedged reads won over the life of the process",
> , i.e. the number of times hedged reads were faster than the original read 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4a5d396abb3373d352ad2df8c2272db018114da
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes