Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7B0D6200C63 for ; Thu, 11 May 2017 22:39:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 799AC160BC7; Thu, 11 May 2017 20:39:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C1191160BB3 for ; Thu, 11 May 2017 22:39:23 +0200 (CEST) Received: (qmail 84240 invoked by uid 500); 11 May 2017 20:39:23 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 84229 invoked by uid 99); 11 May 2017 20:39:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 May 2017 20:39:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 543B21889D2 for ; Thu, 11 May 2017 20:39:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id YLbzmT8y48Yr for ; Thu, 11 May 2017 20:39:18 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 5C58F5F398 for ; Thu, 11 May 2017 20:39:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v4BKdG1i009162; Thu, 11 May 2017 20:39:16 GMT Message-Id: <201705112039.v4BKdG1i009162@ip-10-146-233-104.ec2.internal> Date: Thu, 11 May 2017 20:39:15 +0000 From: "Tim Armstrong (Code Review)" To: Dan Hecht , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5238=3A_transfer_reservations_between_trackers=0A?= X-Gerrit-Change-Id: I21f008abaf1aa4fcd2d854769a603b97589af3b3 X-Gerrit-ChangeURL: X-Gerrit-Commit: c755a61f4af5e322914ba106142d603692991f2f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 11 May 2017 20:39:24 -0000 Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6708 to look at the new patch set (#10). Change subject: IMPALA-5238: transfer reservations between trackers ...................................................................... IMPALA-5238: transfer reservations between trackers This is a primitive needed to implement claiming and distribution of initial reservations. It supports transferring reservation between any two ReservationTrackers under the same query. Also remove the public DecreaseReservation() method, which is now mostly redundant and we have no plans to use. Testing: * Added a test that exercises transfer between trackers at different levels and with different relationships. Change-Id: I21f008abaf1aa4fcd2d854769a603b97589af3b3 --- M be/src/runtime/bufferpool/reservation-tracker-test.cc M be/src/runtime/bufferpool/reservation-tracker.cc M be/src/runtime/bufferpool/reservation-tracker.h 3 files changed, 295 insertions(+), 74 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/6708/10 -- To view, visit http://gerrit.cloudera.org:8080/6708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I21f008abaf1aa4fcd2d854769a603b97589af3b3 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong