Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BB51F200C7E for ; Tue, 9 May 2017 01:23:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B9EE4160BBF; Mon, 8 May 2017 23:23:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0C1B4160BA5 for ; Tue, 9 May 2017 01:23:24 +0200 (CEST) Received: (qmail 72552 invoked by uid 500); 8 May 2017 23:23:24 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 72541 invoked by uid 99); 8 May 2017 23:23:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 May 2017 23:23:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 948D81A0154 for ; Mon, 8 May 2017 23:23:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id kP2LIacKF6hQ for ; Mon, 8 May 2017 23:23:22 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2C0065FBE2 for ; Mon, 8 May 2017 23:23:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v48NNKdd009462; Mon, 8 May 2017 23:23:20 GMT Message-Id: <201705082323.v48NNKdd009462@ip-10-146-233-104.ec2.internal> Date: Mon, 8 May 2017 23:23:20 +0000 From: "Tim Armstrong (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4669=3A_=5BKUTIL=5D_Add_kudu_util_library_to_the_build=2E=0A?= X-Gerrit-Change-Id: I8da798ee55506d6f969416b17c191eb03cb215f5 X-Gerrit-ChangeURL: X-Gerrit-Commit: dfd712c5f79c94c0fc6d058c643a5c39c1f1f056 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 08 May 2017 23:23:25 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5715/7/be/src/kudu/util/status.h File be/src/kudu/util/status.h: Line 122: #ifndef KUDU_LOG > Fixed it properly: the alternative definition was coming from stubs.h, but I don't see a change here -- To view, visit http://gerrit.cloudera.org:8080/5715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8da798ee55506d6f969416b17c191eb03cb215f5 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes