Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C3DD2200C6E for ; Mon, 8 May 2017 17:08:56 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C26EA160BA5; Mon, 8 May 2017 15:08:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 18C50160B99 for ; Mon, 8 May 2017 17:08:55 +0200 (CEST) Received: (qmail 50882 invoked by uid 500); 8 May 2017 15:08:55 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 50865 invoked by uid 99); 8 May 2017 15:08:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 May 2017 15:08:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 83277C233E for ; Mon, 8 May 2017 15:08:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id lVp_FeJQrRuZ for ; Mon, 8 May 2017 15:08:53 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 8F6845F1B3 for ; Mon, 8 May 2017 15:08:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v48F8qvZ021813; Mon, 8 May 2017 15:08:52 GMT Message-Id: <201705081508.v48F8qvZ021813@ip-10-146-233-104.ec2.internal> Date: Mon, 8 May 2017 15:08:52 +0000 From: "Marcel Kornacker (Code Review)" To: Lars Volker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong , Attila Jeges Reply-To: marcel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4815=2C_IMPALA-4817=2C_IMPALA-4819=3A_Write_and_Read_Parquet_Statistics_for_remaining_types=0A?= X-Gerrit-Change-Id: I3ef4a5d25a57c82577fd498d6d1c4297ecf39312 X-Gerrit-ChangeURL: X-Gerrit-Commit: 148014dd24d72a131b6e855c3ff124495118af79 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 08 May 2017 15:08:57 -0000 Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/6563/6/be/src/exec/parquet-column-stats.cc File be/src/exec/parquet-column-stats.cc: Line 104: case TYPE_DECIMAL: > I disabled read support for CHAR columns. Should we also disable write supp how is it written, with padding? http://gerrit.cloudera.org:8080/#/c/6563/8/be/src/exec/parquet-column-stats.h File be/src/exec/parquet-column-stats.h: Line 99: // Copies the memory of 'value' into 'buffer' and make 'value' point to 'buffer'. i didn't realize that this resets 'buffer' ('copies into' can also mean append). -- To view, visit http://gerrit.cloudera.org:8080/6563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ef4a5d25a57c82577fd498d6d1c4297ecf39312 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes