Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A864D200C7B for ; Sat, 6 May 2017 07:09:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A6EEA160BBE; Sat, 6 May 2017 05:09:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id ED9DE160BAF for ; Sat, 6 May 2017 07:09:09 +0200 (CEST) Received: (qmail 11408 invoked by uid 500); 6 May 2017 05:09:09 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 11396 invoked by uid 99); 6 May 2017 05:09:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 May 2017 05:09:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7C9D518832E for ; Sat, 6 May 2017 05:09:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id wl7jjiwrPctv for ; Sat, 6 May 2017 05:09:07 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 6B0FE5F1BA for ; Sat, 6 May 2017 05:09:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v465964u007014; Sat, 6 May 2017 05:09:06 GMT Message-Id: <201705060509.v465964u007014@ip-10-146-233-104.ec2.internal> Date: Sat, 6 May 2017 05:09:06 +0000 From: "Jim Apple (Code Review)" To: Jim Apple , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Mostafa Mokhtar , Dan Hecht Reply-To: jbapple-impala@apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5273=3A_Replace_StringCompare_with_glibc_memcmp=0A?= X-Gerrit-Change-Id: Ie4786a4a75fdaffedd6e17cf076b5368ba4b4e3e X-Gerrit-ChangeURL: X-Gerrit-Commit: cf699c658d09cd9769932d0f79536e264940a6f9 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Sat, 06 May 2017 05:09:10 -0000 Jim Apple has posted comments on this change. Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6768/2/be/src/benchmarks/string-compare-benchmark.cc File be/src/benchmarks/string-compare-benchmark.cc: PS2, Line 202: suite.AddBenchmark("Original", TestStringCompare, &data); : suite.AddBenchmark("Simplified, broken", TestStringCompare, &data); : suite.AddBenchmark("Simplified, fixed, strncmp", : TestStringCompare>, &data); : suite.AddBenchmark("Simplified, fixed, memcmp", : TestStringCompare>, &data); > Sure. Or why do we even need 1,2,3? I haven't looked at this in enough deta Done -- To view, visit http://gerrit.cloudera.org:8080/6768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4786a4a75fdaffedd6e17cf076b5368ba4b4e3e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Mostafa Mokhtar Gerrit-HasComments: Yes