Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E49B4200C7B for ; Sat, 6 May 2017 00:44:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E3265160BBE; Fri, 5 May 2017 22:44:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 34393160BAF for ; Sat, 6 May 2017 00:44:26 +0200 (CEST) Received: (qmail 6843 invoked by uid 500); 5 May 2017 22:44:25 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 6832 invoked by uid 99); 5 May 2017 22:44:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 May 2017 22:44:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9F75F188A6B for ; Fri, 5 May 2017 22:44:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ZKLb7-FhYDZU for ; Fri, 5 May 2017 22:44:23 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id AD3D35F36B for ; Fri, 5 May 2017 22:44:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v45MiNRV000967; Fri, 5 May 2017 22:44:23 GMT Message-Id: <201705052244.v45MiNRV000967@ip-10-146-233-104.ec2.internal> Date: Fri, 5 May 2017 22:44:23 +0000 From: "Alex Behm (Code Review)" To: Joe McDonnell , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3654=3A_Parquet_stats_filtering_for_IN_predicate=0A?= X-Gerrit-Change-Id: I4a88963a7206f40a867e49eceeaf03fdd4f71997 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8cfb888c3c9336c5edee124897bdaab489c360c7 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 05 May 2017 22:44:27 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-3654: Parquet stats filtering for IN predicate ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/6810/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: Line 379: for (int i = 1; i < children.size(); i++) { ++i Line 383: if (!(child instanceof LiteralExpr)) return; isLiteral() is more readable Line 384: LiteralExpr literal_child = (LiteralExpr) child; Java style :) literalChild Line 394: BinaryPredicate min_bound = new BinaryPredicate(BinaryPredicate.Operator.GE, minBound, maxBound http://gerrit.cloudera.org:8080/#/c/6810/1/testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering.test File testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering.test: Line 29: # Test a variety of types Add one query with the negative cases: * IN list contains NULL * IN list contains non-Literals * NOT IN * non-SlotRef expr as first child of the InPredicate http://gerrit.cloudera.org:8080/#/c/6810/1/testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test File testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test: Line 300: # Verify NULL prevents using min/max Should be a planner test instead, so we can see that no min/max predicate is generated -- To view, visit http://gerrit.cloudera.org:8080/6810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a88963a7206f40a867e49eceeaf03fdd4f71997 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Alex Behm Gerrit-HasComments: Yes