Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9EC2C200C79 for ; Fri, 5 May 2017 01:18:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9D44D160BC4; Thu, 4 May 2017 23:18:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E3720160BB0 for ; Fri, 5 May 2017 01:18:48 +0200 (CEST) Received: (qmail 45054 invoked by uid 500); 4 May 2017 23:18:48 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 45043 invoked by uid 99); 4 May 2017 23:18:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 May 2017 23:18:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 813E2C4423 for ; Thu, 4 May 2017 23:18:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 4lRoON6xADIL for ; Thu, 4 May 2017 23:18:46 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id AFC835FB48 for ; Thu, 4 May 2017 23:18:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v44NIjVE012825; Thu, 4 May 2017 23:18:45 GMT Message-Id: <201705042318.v44NIjVE012825@ip-10-146-233-104.ec2.internal> Date: Thu, 4 May 2017 23:18:45 +0000 From: "Dan Hecht (Code Review)" To: Jim Apple , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Mostafa Mokhtar Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5273=3A_Replace_StringCompare_with_glibc_memcmp=0A?= X-Gerrit-Change-Id: Ie4786a4a75fdaffedd6e17cf076b5368ba4b4e3e X-Gerrit-ChangeURL: X-Gerrit-Commit: cf699c658d09cd9769932d0f79536e264940a6f9 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 04 May 2017 23:18:49 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6768/1//COMMIT_MSG Commit Message: PS1, Line 17: (repeat("a", 2048)); > Where can I find information about the nightly perf test suite? Alternatively, you could run any other benchmark that gives more comprehensive coverage of the impala code paths. Or explain why the query you've run does give us all the coverage we need. http://gerrit.cloudera.org:8080/#/c/6768/2/be/src/runtime/string-value.inline.h File be/src/runtime/string-value.inline.h: PS2, Line 40: memcmp why not strncmp()? oh, I guess memcmp() is faster since it doesn't need to check for null termination (and we don't need that on this path)? -- To view, visit http://gerrit.cloudera.org:8080/6768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4786a4a75fdaffedd6e17cf076b5368ba4b4e3e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Mostafa Mokhtar Gerrit-HasComments: Yes