Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9045C200C68 for ; Wed, 3 May 2017 21:43:01 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8EC72160BB5; Wed, 3 May 2017 19:43:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D4178160BA1 for ; Wed, 3 May 2017 21:43:00 +0200 (CEST) Received: (qmail 78912 invoked by uid 500); 3 May 2017 19:43:00 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 78901 invoked by uid 99); 3 May 2017 19:42:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 May 2017 19:42:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 53CC5C0B3C for ; Wed, 3 May 2017 19:42:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id QDG8DEfOfmY2 for ; Wed, 3 May 2017 19:42:58 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 43C605F36F for ; Wed, 3 May 2017 19:42:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v43Jgu10003704; Wed, 3 May 2017 19:42:56 GMT Message-Id: <201705031942.v43Jgu10003704@ip-10-146-233-104.ec2.internal> Date: Wed, 3 May 2017 19:42:56 +0000 From: "Marcel Kornacker (Code Review)" To: Matthew Jacobs , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Lars Volker , David Ribeiro Alves , Thomas Tauber-Marshall Reply-To: marcel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5137=3A_Support_Kudu_UNIXTIME_MICROS_as_Impala_TIMESTAMP=0A?= X-Gerrit-Change-Id: Iae6ccfffb79118a9036fb2227dba3a55356c896d X-Gerrit-ChangeURL: X-Gerrit-Commit: b43a33e27e82e7313fab1602330279e259aa78cd In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 03 May 2017 19:43:01 -0000 Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP ...................................................................... Patch Set 5: (4 comments) quick feedback just for the tests. http://gerrit.cloudera.org:8080/#/c/6526/5/testdata/workloads/functional-query/queries/QueryTest/kudu-overflow-ts.test File testdata/workloads/functional-query/queries/QueryTest/kudu-overflow-ts.test: Line 1: ==== hm, this is basically the same as the other new .test file. leave todo to fix our test driver: we should be able to specify query options in an 'options' section. http://gerrit.cloudera.org:8080/#/c/6526/5/testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test File testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test: Line 6: ts timestamp) no 'null' clause here? PS5, Line 53: 999999 so this is truncation behavior? Line 183: ---- DML_RESULTS: tdata how come this only shows 2 rows? -- To view, visit http://gerrit.cloudera.org:8080/6526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6ccfffb79118a9036fb2227dba3a55356c896d Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes