Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A6EB9200C68 for ; Wed, 3 May 2017 18:50:35 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A5826160BBA; Wed, 3 May 2017 16:50:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EAF1B160BB5 for ; Wed, 3 May 2017 18:50:34 +0200 (CEST) Received: (qmail 23302 invoked by uid 500); 3 May 2017 16:50:34 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 23200 invoked by uid 99); 3 May 2017 16:50:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 May 2017 16:50:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8CE12188332 for ; Wed, 3 May 2017 16:50:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id WK9vtV8S8k1i for ; Wed, 3 May 2017 16:50:33 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id B6B735FB2C for ; Wed, 3 May 2017 16:50:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v43GoWI0028429; Wed, 3 May 2017 16:50:32 GMT Message-Id: <201705031650.v43GoWI0028429@ip-10-146-233-104.ec2.internal> Date: Wed, 3 May 2017 16:50:32 +0000 From: "Dan Hecht (Code Review)" To: Michael Ho , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Attila Jeges , Taras Bobrovytsky Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5246=3A_UDF=27s_Close=28=29_should_handle_Expr=27s_preparation_failure=0A?= X-Gerrit-Change-Id: Id2c689246ed4f8dd38f104fa35904f3926a7039c X-Gerrit-ChangeURL: X-Gerrit-Commit: c7d4f2987dd8b50e3aef18356ced38c3da08e52f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 03 May 2017 16:50:35 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-5246: UDF's Close() should handle Expr's preparation failure ...................................................................... Patch Set 1: Free() already has a null check. What am I missing? void FunctionContext::Free(uint8_t* buffer) noexcept { assert(!impl_->closed_); if (buffer == NULL) return; -- To view, visit http://gerrit.cloudera.org:8080/6757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2c689246ed4f8dd38f104fa35904f3926a7039c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Taras Bobrovytsky Gerrit-HasComments: No