Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D6E122009DC for ; Tue, 2 May 2017 19:16:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D5609160B9D; Tue, 2 May 2017 17:16:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 28876160BAB for ; Tue, 2 May 2017 19:16:25 +0200 (CEST) Received: (qmail 507 invoked by uid 500); 2 May 2017 17:16:24 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 463 invoked by uid 99); 2 May 2017 17:16:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 May 2017 17:16:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C0D31C04EF for ; Tue, 2 May 2017 17:16:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 0ruq-0ucTiSb for ; Tue, 2 May 2017 17:16:23 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id E837F5FB2C for ; Tue, 2 May 2017 17:16:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v42HGMxt002896; Tue, 2 May 2017 17:16:22 GMT Message-Id: <201705021716.v42HGMxt002896@ip-10-146-233-104.ec2.internal> Date: Tue, 2 May 2017 17:16:21 +0000 From: "Jim Apple (Code Review)" To: John Russell , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple , zi+zicl@cloudera.com, Zoltan Ivanfi Reply-To: jbapple-impala@apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3973=3A_optional_3rd_and_4th_arguments_for_instr=28=29=2E=0A?= X-Gerrit-Change-Id: I17268bdb480230938f94559fe1eabe34ac2448b7 X-Gerrit-ChangeURL: X-Gerrit-Commit: 429b4d6cf48b4d7ccbbffeef3e4e97bb7ca9c8c3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 02 May 2017 17:16:26 -0000 Jim Apple has posted comments on this change. Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr(). ...................................................................... Patch Set 5: Any updates on this? The comment about line 335 was left on January 3rd. -- To view, visit http://gerrit.cloudera.org:8080/5589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17268bdb480230938f94559fe1eabe34ac2448b7 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Zoltan Ivanfi Gerrit-Reviewer: zi+zicl@cloudera.com Gerrit-HasComments: No