impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5262: test analytic order by random fails with assert
Date Mon, 01 May 2017 23:17:56 GMT
Thomas Tauber-Marshall has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6775

Change subject: IMPALA-5262: test_analytic_order_by_random fails with assert
......................................................................

IMPALA-5262: test_analytic_order_by_random fails with assert

This was a poorly written test that relies on assumptions about
the behavior of 'rand' and the order that rows get processed in
a table that Impala doesn't actually guarantee.

Its also unnecessary as test_order_by_random verifies that sort
expr materialization behaves as expected and the PlannerTest
sort-expr-materialization verified that exprs are materialized
for analytic functions as appropriate.

Change-Id: If1ba8154c2b6a8d508916d85391b95885ef915a9
---
M tests/query_test/test_sort.py
1 file changed, 0 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/6775/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If1ba8154c2b6a8d508916d85391b95885ef915a9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>

Mime
View raw message