impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5378: Disk IO manager needs to understand ADLS
Date Wed, 31 May 2017 22:48:26 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS
......................................................................


Patch Set 1:

> (2 comments)
 > 
 > > (2 comments)
 > >
 > > questions:
 > > - what about insert staging for adls (in coordinator.cc?
 > 
 > ADLS claims to have atomic renames. So we don't need to worry about
 > that like we did for S3.
 > 
 > > - what about hdfs-fs-cache, does that need to be extended?
 > 
 > I'm not sure which cache you mean, so I'll address both. The file
 > handle cache at this point doesn't support caching remote file
 > handles. Also, we don't support SET CACHED for S3 and ADLS at this
 > point.

i meant runtime/hdfs-fs-cache.{cc,h}.

-- 
To view, visit http://gerrit.cloudera.org:8080/7033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I067f053fec941e3631610c5cc89a384f257ba906
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message