impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5391: remove C++11 from UDF header
Date Wed, 31 May 2017 07:04:15 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5391: remove C++11 from UDF header
......................................................................


IMPALA-5391: remove C++11 from UDF header

This replaces the C++11 idiom with equivalent C++98 code. The code was
added to address a clang-tidy warning about missing virtual
destructors, which the new code should also address.

Change-Id: Ic10906027e3644e4d42ad20fcd6abda1c24fefa6
Reviewed-on: http://gerrit.cloudera.org:8080/7024
Reviewed-by: Henry Robinson <henry@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/udf/uda-test-harness.h
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Henry Robinson: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic10906027e3644e4d42ad20fcd6abda1c24fefa6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins

Mime
View raw message