impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4988: Add query option read parquet statistics
Date Wed, 31 May 2017 01:13:29 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4988: Add query option read_parquet_statistics
......................................................................


Patch Set 2:

(5 comments)

Thank you for the reviews. Please see PS2.

http://gerrit.cloudera.org:8080/#/c/7001/1/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 632: 
> okay to ignore, but consider putting this inside EvaluateStatsConjuncts(). 
Done


http://gerrit.cloudera.org:8080/#/c/7001/1/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:

PS1, Line 243: parquet_read_statistics
> consider renaming this so the "parquet" comes first like all the other parq
I renamed it to parquet_read_statistics. The flag will eventually control more than filtering.


http://gerrit.cloudera.org:8080/#/c/7001/1/common/thrift/ImpalaService.thrift
File common/thrift/ImpalaService.thrift:

> What kind of controls do we have to help ensure that files like query-optio
There's a DCHECK in query-options.h:

  DCHECK_EQ(_TImpalaQueryOptions_VALUES_TO_NAMES.size(),\
      TImpalaQueryOptions::READ_PARQUET_STATISTICS + 1);\


http://gerrit.cloudera.org:8080/#/c/7001/1/testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test
File testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test:

Line 452: # query option.
> how does this actually verify that stats were disabled? maybe check the sta
Done


Line 455: ---- RESULTS
> How about a test for 
What is the difference to =0?


-- 
To view, visit http://gerrit.cloudera.org:8080/7001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I427f7fde40d0f4b703751e40f3c2109a850643f7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message