impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5363: Reset probe batch after reaching limit
Date Tue, 30 May 2017 23:30:31 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5363: Reset probe_batch_ after reaching limit
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7014/2/testdata/workloads/functional-query/queries/QueryTest/joins.test
File testdata/workloads/functional-query/queries/QueryTest/joins.test:

Line 734: # IMPALA-5363: Reset probe_batch_ after reaching limit.
> I think this test should be moved to subplans.test. We can't run against ne
Disregard the NLJ comment - was looking at the wrong patchset. The other part still applies.


-- 
To view, visit http://gerrit.cloudera.org:8080/7014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafd621d33a4e2fac42391504566ffd8dd0e18a67
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message