impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5363: Reset probe batch after reaching limit.
Date Tue, 30 May 2017 20:48:04 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5363: Reset probe_batch_ after reaching limit.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7014/1/be/src/exec/partitioned-hash-join-node.cc
File be/src/exec/partitioned-hash-join-node.cc:

Line 498:     probe_batch_->Reset();
It looks like TransferResourceOwnership() already calls Reset(), so we can skip that (I forgot
the details of how that worked).


-- 
To view, visit http://gerrit.cloudera.org:8080/7014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafd621d33a4e2fac42391504566ffd8dd0e18a67
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message