impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function
Date Tue, 30 May 2017 15:17:52 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5030: Adds support for NVL2() function
......................................................................


Patch Set 3:

(2 comments)

Looks good aside from a couple of minor things.

http://gerrit.cloudera.org:8080/#/c/7000/3/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

PS3, Line 5643: TimestampValue
Doesn't compile - duplicate declaration of then_val/else_val about.


PS3, Line 5644: TRUE
Maybe make this FALSE? Just for some variety.


-- 
To view, visit http://gerrit.cloudera.org:8080/7000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide0352d611322de637a61a0004c39f5663192c52
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vttran@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message