impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4164: Avoid overly aggressive inlining in LLVM IR
Date Sat, 27 May 2017 19:33:03 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4164: Avoid overly aggressive inlining in LLVM IR

Patch Set 7:

File be/src/codegen/

Line 645:   // Check that there are no calls to FunctionContextImpl::GetConstFnAttr(). These
should all
> See my other comment about whether InlineHint is required.
File be/src/codegen/

Line 700:   // Set the cross-compiled functions' "target-cpu" and "target-features" to
> It isn't limited to cross-compiled functions is it?

Line 704:   // If there is no "noinline" attribute, add an inline hint to the function.
> Instead of adding the hint everywhere it seems better to adjust the inlinin
In fact, it may be simpler to just use the default value (225) with -O2 optimization level.
The new patch removes all inline hint and relies on the inlining pass to do the right thing.
I ran some standard perf benchmarks with PS8 in the 16-node cluster and there was no regression.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d87ae8d222b415587e7320cb9072e4a8d6615ce
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message