impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Loads all TPC-DS tables
Date Fri, 26 May 2017 01:32:38 GMT
Michael Ho has posted comments on this change.

Change subject: Loads all TPC-DS tables
......................................................................


Patch Set 7:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6877/7//COMMIT_MSG
Commit Message:

PS7, Line 7: Loads all TPC-DS tables
> Jira?
There is only a downstream JIRA tracking this. I will file an upstream JIRA for it.


http://gerrit.cloudera.org:8080/#/c/6877/7/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:

PS7, Line 365:                                    impala_home = os.getenv("IMPALA_HOME"),
             :                                    hint = insert_hint)
> Please remove spaces around = as above.
Done


http://gerrit.cloudera.org:8080/#/c/6877/7/testdata/datasets/tpcds/tpcds_schema_template.sql
File testdata/datasets/tpcds/tpcds_schema_template.sql:

PS7, Line 27: cc_rec_start_date         string
            : cc_rec_end_date           string
> Here and likely elsewhere, there are column type differences between the sp
The schema mostly matches what we use for nightly perf testing. I agree that we should probably
change some of these to timestamp but that it may require changing some existing table such
as date_dim so I didn't want to do it in this change.

Some other notable difference from the spec is that we use bigint for certain columns such
as ss_ticket_number as it may overflow a 32-bit integer when the scale gets large enough.


-- 
To view, visit http://gerrit.cloudera.org:8080/6877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5277245fd20827c9c09ce5c1a7a37266ca476b9
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message