impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5375: Builds on CentOS 6.4 failing with broken python dependencies
Date Fri, 26 May 2017 01:14:56 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-5375: Builds on CentOS 6.4 failing with broken python dependencies
......................................................................


Patch Set 1:

(3 comments)

Tim mentioned a good point. Instead of splitting the requirements into a seperate adls-compiled-requirements.txt,
we can just move these requirements to adls-requirements.txt and set the compiler environment
'CC' while installing those. So, I've made that change instead as it keeps the patch much
simpler.

http://gerrit.cloudera.org:8080/#/c/6995/1/infra/python/bootstrap_virtualenv.py
File infra/python/bootstrap_virtualenv.py:

PS1, Line 228: ret = install_compiled_deps_if_possible(COMPILED_REQS_PATH)
             :   if ret == False: return False
             :   if os.environ.get('TARGET_FILESYSTEM') == "adls":
             :     ret = install_compiled_deps_if_possible(ADLS_COMPILED_REQS_PATH)
             :     if ret == False: return False
> this might be more elegantly expressed as:
Not necessary anymore after the refactor.


Line 235: def install_adls_deps():
> why not add the compiled deps logic here?
Not necessary anymore after the refactor.


PS1, Line 236: 6
> elsewhere the min reqs for the compiled_deps is said to be 6.7. Can you mak
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8aff00aeaab92c2d885a6e457ea351431483fa04
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message