impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5375: Builds on CentOS 6.4 failing with broken python dependencies
Date Fri, 26 May 2017 00:11:40 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5375: Builds on CentOS 6.4 failing with broken python dependencies
......................................................................


Patch Set 1:

(3 comments)

Can you mention the testing you do (when it's complete) in the commit msg?

http://gerrit.cloudera.org:8080/#/c/6995/1/infra/python/bootstrap_virtualenv.py
File infra/python/bootstrap_virtualenv.py:

PS1, Line 228: ret = install_compiled_deps_if_possible(COMPILED_REQS_PATH)
             :   if ret == False: return False
             :   if os.environ.get('TARGET_FILESYSTEM') == "adls":
             :     ret = install_compiled_deps_if_possible(ADLS_COMPILED_REQS_PATH)
             :     if ret == False: return False
this might be more elegantly expressed as:

  REQS = [COMPILED_REQS_PATH]
  if os.environ.get("TARGET_FILESYSTEM") == "adls":
    REQS += ADLS_COMPILED_REQS_PATH
  for req in REQS:
    if not install_compiled_deps_if_possible(req): return False
  return True


Line 235: def install_adls_deps():
why not add the compiled deps logic here?


PS1, Line 236: 6
elsewhere the min reqs for the compiled_deps is said to be 6.7. Can you make these consistent?


-- 
To view, visit http://gerrit.cloudera.org:8080/6995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8aff00aeaab92c2d885a6e457ea351431483fa04
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message